Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token contstructor required #1

Closed
orloffv opened this issue Jul 2, 2015 · 2 comments
Closed

Token contstructor required #1

orloffv opened this issue Jul 2, 2015 · 2 comments

Comments

@orloffv
Copy link

orloffv commented Jul 2, 2015

public function __construct($token, $async = false, $http_client_handler = null)
$this->accessToken = isset($token) ? $token : getenv(static::BOT_TOKEN_ENV_NAME);

maybe use
public function __construct($token = null, $async = false, $http_client_handler = null)?
@irazasyed
Copy link
Owner

Thanks for pointing out. Seems like i missed that. Pushing changes now 👍

@irazasyed
Copy link
Owner

Pushed a patch release - v0.2.1 and credited!

@skorotkiewicz skorotkiewicz mentioned this issue Jul 18, 2015
Closed
jonnywilliamson referenced this issue Apr 21, 2016
@irazasyed
Type hint in bots manager.
ae214d0
@Faydaen Faydaen mentioned this issue Apr 27, 2016
Closed
@akeinhell akeinhell mentioned this issue Sep 30, 2016
Closed
@chaskayu chaskayu mentioned this issue Nov 14, 2016
Closed
@MrFiregore MrFiregore mentioned this issue Jan 24, 2017
Closed
@amirpiri amirpiri mentioned this issue Jun 30, 2017
Closed
@ghost ghost mentioned this issue Feb 25, 2018
Closed
@antonr45 antonr45 mentioned this issue Feb 22, 2020
Closed
@duquesimba duquesimba mentioned this issue Apr 18, 2022
Closed
@asteriskDevelop asteriskDevelop mentioned this issue Apr 21, 2022
Closed
irpcpro added a commit to irpcpro/telegram-bot-sdk that referenced this issue Apr 3, 2023
@irpcpro
Update TelegramRequest.php
23c5f81 
in construct when properties could be null, type of these setter methods value should be also include type of null.
in other case these errors will throw :
Argument irazasyed#1 ($accessToken) must be of type string, null given
Argument irazasyed#1 ($endpoint) must be of type string, null given
Argument irazasyed#1 ($method) must be of type string, null given
@irpcpro irpcpro mentioned this issue Apr 3, 2023
Merged
@guanzhihua168 guanzhihua168 mentioned this issue Jun 15, 2023
Closed
@tahola tahola mentioned this issue Jun 25, 2023
Closed
@Maatify Maatify mentioned this issue Jul 13, 2023
Closed
@mammothcoding mammothcoding mentioned this issue Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orloffv @irazasyed