Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes for macOS #26

Merged
merged 3 commits into from
Dec 28, 2022
Merged

minor fixes for macOS #26

merged 3 commits into from
Dec 28, 2022

Conversation

sfjohnston
Copy link
Contributor

There were a few negative hex values that macOS prefers to see as ints.
Also, there was a small scope-related bug.

There were two lines that presumed Result was set that were left
out of the conditional checking for Result.
One of these was using Result->PlatformData, and has been adjusted
to use PlatformData that is pulled via GetPlatformData() on ENGINE_MAJOR_VERSION>4.
@irajsb irajsb merged commit 69a1a57 into irajsb:main Dec 28, 2022
@irajsb
Copy link
Owner

irajsb commented Dec 28, 2022

Thank you for improving this library

@sfjohnston
Copy link
Contributor Author

sfjohnston commented Dec 29, 2022 via email

@sfjohnston
Copy link
Contributor Author

sfjohnston commented Dec 29, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants