Remove tx-signer feature
#764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While TMKMS-backed transaction signer support sounds great in theory, this feature implements the pre-Protobuf transaction format (Amino) which is no longer commonly in use on Cosmos chains. It also uses a bespoke JSON RPC, whereas a more modern implementation would use gRPC. It comes with a fairly high maintenance burden in that it has a number of cryptographic dependencies transitively via the now defunct `stdtx` crate.
Shella
approved these changes
Oct 9, 2023
This was referenced Oct 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While TMKMS-backed transaction signer support sounds great in theory, this feature implements the pre-Protobuf transaction format (Amino) which is no longer commonly in use on Cosmos chains.
It also uses a bespoke JSON RPC, whereas a more modern implementation would use gRPC.
It comes with a fairly high maintenance burden in that it has a number of cryptographic dependencies transitively via the now defunct
stdtxcrate.