Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修正云音乐 v3.0 Mac 生成的 NCM 文件 + 代码重构 #23

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

um-lsr
Copy link
Contributor

@um-lsr um-lsr commented Sep 13, 2024

修正了云音乐 v3.0 Mac 生成的 ncm 封面格式问题(测试文件参考 taurusxin/ncmdump#26 的附件),以及重构了部分代码。

@iqiziqi iqiziqi self-requested a review September 16, 2024 16:14
@iqiziqi
Copy link
Owner

iqiziqi commented Sep 16, 2024

Thanks for your contribution.

@iqiziqi
Copy link
Owner

iqiziqi commented Sep 16, 2024

When I use the test file (taurusxin/ncmdump#26 attachment) for testing, he has the following error, I think this PR needs to be modified.

当我使用测试文件(taurusxin/ncmdump#26 的附件)进行测试时,他发生了如下的错误,我觉得这个 PR 还需要再处理一下。

[█████████████████████████████████████░░░] | 95%|  16.55 MiB/17.50 MiB
thread '<unnamed>' panicked at crates/ncmdump-bin/src/utils.rs:2:17:
range end index 12 out of range for slice of length 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at crates/ncmdump-bin/src/main.rs:142:25:
called `Result::unwrap()` on an `Err` value: Any { .. }

@um-lsr
Copy link
Contributor Author

um-lsr commented Sep 16, 2024

已修正。之前的问题是程序会尝试在封面数据为空的情况时依旧尝试检测或嵌入。

@iqiziqi
Copy link
Owner

iqiziqi commented Sep 16, 2024

Can you provide Netease Cloud Music for Mac 3.0 installation package or upgrade method?

你可以提供网易云音乐 Mac 3.0 版本的安装包或升级方法吗?

@um-lsr
Copy link
Contributor Author

um-lsr commented Sep 16, 2024

我没有 Mac,但我看网上有流传这个安装包地址:

https://d3.music.126.net/f5368d90-0998-496c-bf79-c198f27ce9b6.dmg

@iqiziqi
Copy link
Owner

iqiziqi commented Sep 16, 2024

Thanks a lot.

@iqiziqi iqiziqi merged commit 3779ff4 into iqiziqi:master Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants