Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate config settings correctly #670

Closed
wants to merge 1 commit into from

Conversation

jcb91
Copy link
Member

@jcb91 jcb91 commented Jul 17, 2016

from old config name to new jupyter_nbextensions_configurator

fixes #667

also addresses the rename issue mentioned in #653 (comment) (although doesn't fix the bulk of #653)

from old `config` name to new `jupyter_nbextensions_configurator`
@juhasch
Copy link
Member

juhasch commented Jul 18, 2016

I think this PR looks good.
The one thing I am unsure about is the dependency on jupyter_nbextensions_configurator in configure_nbextension.py generally. IMO we should separate extensions and the configurator.

@jcb91
Copy link
Member Author

jcb91 commented Jul 18, 2016

we should separate extensions and the configurator

yes, I guess we could, it hadn't really occurred to me. In that case we'd need to edit more docs to reflect the change, as a lot of things refer to the config extension provided by this repo. Tbh, this PR is a bit redundant given #671, anyway (since 671 already does this migration).

@juhasch
Copy link
Member

juhasch commented Jul 18, 2016

I think if we move the repository together with #671 to jupyter-contrib, we might leave this repo in a retired state (with links to the new repo). In this case it would make sense to decouple this repo from others, I believe.

@jcb91
Copy link
Member Author

jcb91 commented Jul 18, 2016

we might leave this repo in a retired state (with links to the new repo)

Yes, that sounds like a reasonable plan.

One slight issue (ha!) is that if we leave this repo here, we'll have to think of some way to sensibly migrate any outstanding issues to the new repo, and get people to add new ones in the correct place, etc. - perhaps asking github to migrate to jupyter-contrib might make that simpler?

@juhasch
Copy link
Member

juhasch commented Jul 18, 2016

Yes, I guess migrating the complete repo is better in the end and will save us some headache.

@juhasch
Copy link
Member

juhasch commented Jul 26, 2016

Closed after restructuring of repo

@juhasch juhasch closed this Jul 26, 2016
@jcb91 jcb91 deleted the config-migrate branch July 28, 2016 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: No module named 'nbextensions'
2 participants