Skip to content

Commit

Permalink
[qa] Always check for wimboot startup banner in log output
Browse files Browse the repository at this point in the history
Many test cases do not include any explicit log message checks, and
can therefore pass even if the log output mechanism is non-functional.

Add an unconditional log message check for the wimboot startup banner,
to ensure that all tests require a working log output mechanism in
order to pass.

Signed-off-by: Michael Brown <[email protected]>
  • Loading branch information
mcb30 committed Nov 28, 2023
1 parent fc913e3 commit b24fdd0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/testwimboot
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ for test_file in args.test:
continue

# Check for required log messages
logcheck.append(r'wimboot v\d+\.\d+\.\d+ -- Windows Imaging Format')
with open(logfile, 'rt') as fh:
log = fh.read()
logfail = [x for x in logcheck if not re.search(x, log)]
Expand Down

0 comments on commit b24fdd0

Please sign in to comment.