Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another example of device support being checked later than expected #1488

Closed
wants to merge 1 commit into from

Conversation

jbemmel
Copy link
Collaborator

@jbemmel jbemmel commented Nov 3, 2024

Being pedantic here, feel free to ignore or de-prioritize - but here's another example of the EVPN module producing an error while the "real" error is lack of device support

@jbemmel jbemmel force-pushed the module-support-check-issues branch from 885cb53 to 5180325 Compare November 3, 2024 16:12
@ipspace
Copy link
Owner

ipspace commented Nov 3, 2024

So, using your test case, I got

[ERRORS]  Errors found in test.yml
[VALUE]   evpn: VRF test in node n1 cannot have evpn.bundle attribute
[HINT]    evpn.bundle attribute can be used only in global VRF definition
[FATAL]   Cannot proceed beyond this point due to errors, exiting

What's your point?

@jbemmel
Copy link
Collaborator Author

jbemmel commented Nov 3, 2024

The vmx device doesn't support the EVPN module, that should be the error

@ipspace
Copy link
Owner

ipspace commented Nov 3, 2024

The vmx device doesn't support the EVPN module, that should be the error

Theoretically, you're correct. In practice, you get a valid error message, and if you find an EVPN attribute that can be applied to a node VRF, you'll probably get the expected error message as well.

@ipspace ipspace closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants