Option to enable/disable pubsub announcement #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it optional to send announcements via gossip pubsub, instead of always sending them if a libp2p host is present. This PR also separates announcement sender configuration from publisher configuration. Other minor updates: - Always close http response body - Update go-libp2p and go-libipni Fixes issue #364
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
- Coverage 50.29% 50.22% -0.08%
==========================================
Files 61 61
Lines 5032 5053 +21
==========================================
+ Hits 2531 2538 +7
- Misses 2184 2198 +14
Partials 317 317 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it optional to send announcements via gossip pubsub, instead of always sending them if a libp2p host is present.
This PR also separates announcement sender configuration from publisher configuration.
Other minor updates:
Fixes issue #364
Note: new options and config file remain backward-compatible with boost and with previous indexer-provider installations.