Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Lead maintainer #127

Merged
merged 5 commits into from
May 6, 2018
Merged

Lead maintainer #127

merged 5 commits into from
May 6, 2018

Conversation

daviddias
Copy link
Member

@daviddias daviddias requested a review from vmx May 1, 2018 11:52
@daviddias daviddias mentioned this pull request May 1, 2018
Merged
@daviddias daviddias mentioned this pull request May 1, 2018
Closed
vmx
vmx approved these changes May 2, 2018
View reviewed changes
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all these changes. I generally prefer having a clean Git history, so that you can later see what was going on. If all those commits are squashed into one it mixes a lot of things.

README updates and dependency updates shouldn't be in the same commit, as it makes reverting things hard/bad if a dependency breaks things.

Anyway as there's a lots of things going, feel free to merge it as it currently is :)

@daviddias
Copy link
Member Author

@vmx understood and agree with that best practice. Let's make sure to encourage that pattern always. Merging here for the sake of not spending extra time with this PR. Thank you.

@daviddias daviddias merged commit 0ffd30b into master May 6, 2018
@daviddias daviddias deleted the lead-maintainer branch May 6, 2018 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vmx vmx vmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviddias @vmx