This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Prefer const over let #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
mikeal
approved these changes
Oct 11, 2018
|
CI passed: https://ci.ipfs.team/blue/organizations/jenkins/IPLD%2Fjs-ipld-dag-cbor/detail/PR-82/3/pipeline/ Thanks @LinusU for that change. We use a special format for the commit message as outlined in the JS Code Guidelines. This way changes show up in the commit log automatically. I'll fix the message for now while merging. |
|
I'm fixing the messages for the other PRs now, sorry about that 👍 Thanks for fixing it ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to comply with this new standard rule☺️
standard/eslint-config-standard#133