This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
fix: remove node globals #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add buffer update borc
56 tasks
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 96.11% 96.19% +0.07%
==========================================
Files 3 3
Lines 103 105 +2
==========================================
+ Hits 99 101 +2
Misses 4 4
Continue to review full report at Codecov.
|
rvagg
reviewed
Mar 26, 2020
package.json
Outdated
| @@ -37,7 +37,8 @@ | |||
| }, | |||
| "homepage": "https://github.com/ipld/js-ipld-dag-cbor", | |||
| "dependencies": { | |||
| "borc": "^2.1.0", | |||
| "borc": "hugomrdias/borc#fix/remove-node-globals", | |||
There was a problem hiding this comment.
we should get a new borc release out soon, so this probably isn't ideal
There was a problem hiding this comment.
Yes ofc forgot to mention it in the op
rvagg
approved these changes
Mar 26, 2020
vmx
approved these changes
Mar 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add buffer
update borc