-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header error tests #76
Conversation
Hm, why not merge #75 first? otherwise the review gets tricky :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure on the order of PRs that are open. If this pulls other PRs in, would it make sense to close the other ones?
Left a bunch of questions.
LGTM 🍻
Ref: ipld/js-car#28 the primary difference with js-car is that go-car requires a non-empty roots array whereas js-car is fine with empty roots array, hence the test fixture differences
6c4abc8
to
2b1e477
Compare
okie dokie, this is much simpler to review now, just the relevant changes and some .gitignore action |
caa559e
to
03f73dc
Compare
Also pulls in #74 and #75
Ref: ipld/js-car#28
the primary difference with js-car is that go-car requires a non-empty roots array whereas js-car is fine with empty roots array, hence the test fixture differences