Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read/Write blockstore should support resuming #98

Closed
masih opened this issue Jun 23, 2021 · 3 comments · Fixed by #147
Closed

Read/Write blockstore should support resuming #98

masih opened this issue Jun 23, 2021 · 3 comments · Fixed by #147
Labels
P2 Medium: Good to have, but can wait until someone steps up v2-before-release
Milestone

Comments

@masih
Copy link
Member

masih commented Jun 23, 2021

When writing to a blockstore, the write might fail before the blockstore writes are "finalised/flushed". The API should support resuming writes, picking up where it left off.

This is a must for Ignite requirements.

@masih masih added this to the CAR v2 milestone Jun 23, 2021
@willscott
Copy link
Member

while each put should ensure the block is durable, we can assume that the need to resume is rare in comparison to the writes, so it is likely an acceptable tradeoff to not serialize the index until finalization, and instead re-generate the partial index of what has been written so far on resumption

@raulk
Copy link
Member

raulk commented Jun 25, 2021

For the sake of completeness, another possibility would be to restart the transfer from 0, but this is desirable.

@masih
Copy link
Member Author

masih commented Jul 9, 2021

Implemented in #147

@masih masih closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium: Good to have, but can wait until someone steps up v2-before-release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants