Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta Issue] Replace Badger in Deal Making with CARv2 and the Sharded DAG Store and test with MRA #6673

Closed
18 of 20 tasks
aarshkshah1992 opened this issue Jul 4, 2021 · 2 comments
Labels
team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Milestone

Comments

@aarshkshah1992
Copy link
Contributor

aarshkshah1992 commented Jul 4, 2021

This is a meta-issue to track the work of replacing Badger from Filecoin deal making with CARv2 and the Sharded DAG Store and do some solid testing along with the MRA changes to ensure a smooth landing.


Pending CARv2 features


Sharded DAG Store

  • TODO.

Markets


Lotus


Migration

  • Migration of existing storage client data imports in Badger to CARv2 files:

  • Iterate over all the imported payloads in the storage client's Badger store and migrate them to CARv2 files so clients don't have to re-import them. Maybe don't clean up the Badger store right away so client can downgrade without losing imports.

  • Register Shards for all active storage deals on the Miner with the Sharded DAG Store. add migration to register deals as shards go-fil-markets#570

  • Iterate over all active storage deals on a Miner and register shards for all of them with the Sharded DAG Store so we can serve retrievals for deals made before the upgrade.

  • Raise PR against integrate DAG store and CARv2 in deal-making #6671.


### Testground testing (MRA + CARv2 changes)

  • Upgraded client -> upgraded miner (Online storage deal and retrieval).
  • Upgraded client -> upgraded miner (Offline storage deal and retrieval).
  • Upgraded client-> old miner (Online storage deal and retrieval).
  • Upgraded client-> old miner (Offline storage deal and retrieval).
  • Old client -> upgraded miner (Online storage deal and retrieval).
  • Old client -> upgraded miner (Offline storage deal and retrieval).

Manual testing on Mainnet (MRA + CARv2 changes)

  • Upgraded client -> upgraded miner (Online storage deal and retrieval).
  • Upgraded client -> upgraded miner (Offline storage deal and retrieval).
  • Upgraded client-> old miner (Online storage deal and retrieval).
  • Upgraded client-> old miner (Offline storage deal and retrieval).
  • Old client -> upgraded miner (Online storage deal and retrieval).
  • Old client -> upgraded miner (Offline storage deal and retrieval).
  • Old client makes an online storage deal with an old miner -> client upgrades and does a retrieval.
  • Old client makes an online storage deal with an old miner -> miner upgrades and then the old client does a retrieval.

Benchmarking (MRA + CARv2 changes)

  • Benchmark storage deal data transfers of the upgrade vs the use of Badger using our Testground tests.
  • Benchmark retrieval deal data transfers of the upgrade vs the use of Badger using our Testground tests.

=> tracking in #7106.


Testing in the Wild Wild West (MRA + CARv2 changes)

  • Get MinerX fellows to upgrade to the latest changes (will likely need to work with product for this).
  • Ask Dealbot and Estuary (nicely) to upgrade and stress-test storage and retrieval deals against Minxer fellows
@aarshkshah1992 aarshkshah1992 added hint/needs-triaging team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs and removed hint/needs-triaging labels Jul 4, 2021
@aarshkshah1992 aarshkshah1992 changed the title Replace Badger from Deal Making with CARv2 and the Sharded DAG Store Replace Badger from Deal Making with CARv2 and the Sharded DAG Store and test with MRA Jul 4, 2021
@aarshkshah1992 aarshkshah1992 changed the title Replace Badger from Deal Making with CARv2 and the Sharded DAG Store and test with MRA [Meta Issue] Replace Badger from Deal Making with CARv2 and the Sharded DAG Store and test with MRA Jul 4, 2021
@aarshkshah1992 aarshkshah1992 changed the title [Meta Issue] Replace Badger from Deal Making with CARv2 and the Sharded DAG Store and test with MRA [Meta Issue] Replace Badger in Deal Making with CARv2 and the Sharded DAG Store and test with MRA Jul 4, 2021
@aarshkshah1992
Copy link
Contributor Author

cc @jacobheun @raulk for tracking.

@raulk
Copy link
Member

raulk commented Aug 17, 2021

Merged in #6873.

@raulk raulk closed this as completed Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Projects
None yet
Development

No branches or pull requests

3 participants