Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethereum JS and Go codec fixtures and tests #91

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

i-norden
Copy link

@i-norden i-norden commented May 1, 2023

For the TS and Go implementations of the Ethereum IPLD codecs.

One thing to note is that in the Go tests, we have to use prototypes from the TypeSlab over in go-codec-dageth because an error occurs with Union types when trying to use a basicnode builder. More info on that here. I intend to get to the bottom of this as well as wrap up a few other modernization tasks for go-codec-dageth (and ts-dag-eth) (e.g. upgrade deps; add support for Beacon Chain types) but that will be somewhat involved and so would like to checkpoint this work here so that we have working shared fixtures and tests in place for the current state of the Go and TS/JS codecs.

@i-norden
Copy link
Author

i-norden commented May 1, 2023

Some compatibility issues between Go version and geth, I need to bump the version of geth being used in go-codec-dageth.

@i-norden
Copy link
Author

i-norden commented May 1, 2023

That fixed the issue in 1.19, but I don't think we can run the Go ETH IPLD codec tests using Go 1.18 or lower as Geth has begun to use the new atomic types added in Go 1.19+.

@vmx vmx requested a review from rvagg May 2, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant