Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsn update 2.5.0 #50

Merged
merged 3 commits into from
Mar 13, 2023
Merged

vsn update 2.5.0 #50

merged 3 commits into from
Mar 13, 2023

Conversation

rm-Umar
Copy link
Contributor

@rm-Umar rm-Umar commented Mar 13, 2023

fixes #49

@rm-Umar rm-Umar requested a review from UmanShahzad March 13, 2023 06:28
@rm-Umar rm-Umar marked this pull request as draft March 13, 2023 08:25
@rm-Umar rm-Umar marked this pull request as ready for review March 13, 2023 08:43
UmanShahzad
UmanShahzad reviewed Mar 13, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@rm-Umar
Copy link
Contributor Author

rm-Umar commented Mar 13, 2023

@UmanShahzad We can't go on ipinfo 3.0.0 as it doesn't support php 7 and laravel 8 still using symfony/http-foundation that uses php 7.2 so looks like we need to stick with ^2.3.1

@rm-Umar rm-Umar requested a review from UmanShahzad March 13, 2023 11:46
@UmanShahzad
Copy link
Contributor

Alright no issues.

@UmanShahzad UmanShahzad merged commit 8559f78 into master Mar 13, 2023
@UmanShahzad
Copy link
Contributor

@rm-Umar feel free to push a vsn update. Lemme know if you need help.

@UmanShahzad UmanShahzad deleted the laravel10_support branch March 13, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UmanShahzad UmanShahzad Awaiting requested review from UmanShahzad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Laravel 10 Support?
2 participants
@rm-Umar @UmanShahzad