Implements ipinfo tool is_valid
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UmanShahzad
reviewed
Aug 29, 2023
ipinfo/cmd_tool.go
Outdated
| @@ -15,6 +15,7 @@ var completionsTool = &complete.Command{ | |||
| "next": completionsToolNext, | |||
| "prev": completionsToolPrev, | |||
| "is_v4": completionsToolIsV4, | |||
| "isValid": completionsToolIsValid, | |||
ipinfo/cmd_tool_isValid.go
Outdated
| `Usage: %s tool IsValid <ip> | ||
|
|
||
| Description: | ||
| reports whether the Addr is an initialized address (not the zero Addr). |
ipinfo/cmd_tool_isValid.go
Outdated
| Examples: | ||
| %[1]s IsValid "190.87.89.1" | ||
| %[1]s IsValid "2001:0db8:85a3:0000:0000:8a2e:0370:7334" | ||
| %[1]s IsValid "::" |
There was a problem hiding this comment.
Do provide an invalid example if not already
Co-authored-by: Uman Shahzad <[email protected]>
Co-authored-by: Uman Shahzad <[email protected]>
Harisabdullah
changed the title
ipinfo tool isValidipinfo tool is_valid
UmanShahzad
approved these changes
Aug 30, 2023
ipinfo/cmd_tool_isValid.go
Outdated
| `Usage: %s tool is_valid <ip> | ||
|
|
||
| Description: | ||
| reports whether the ip address is an initialized address (not the zero Addr). |
There was a problem hiding this comment.
I left a comment here as well to update this desc to match the short desc above
There was a problem hiding this comment.
Sure! I'll take care of it
UmanShahzad
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.