-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes NULL values in ipinfo <ip>
in YAML
format
#162
Conversation
BE-2226 CLI YAML output should remove `null` entries
For out-of-tier data YAML option should not return any values instead of the current null response.
Preferred response:
This will match our normal response:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make this change in the actual github.com/ipinfo/go repo and update the version, then do go mod vendor
here.
"github.com/fatih/color" | ||
"github.com/ipinfo/cli/lib/complete" | ||
"github.com/ipinfo/cli/lib/complete/predict" | ||
"github.com/ipinfo/go/v2/ipinfo" | ||
"github.com/spf13/pflag" | ||
"net" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrongly placed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Harisabdullah can you quickly wrap this one up by updating the dependency? Then we're good to close
No description provided.