Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

splitcidr #121

Merged
merged 9 commits into from
Sep 28, 2022
Merged

splitcidr #121

merged 9 commits into from
Sep 28, 2022

Conversation

rm-Umar
Copy link
Contributor

@rm-Umar rm-Umar commented Sep 20, 2022

fixes #110

@rm-Umar rm-Umar marked this pull request as draft September 20, 2022 12:40
@rm-Umar rm-Umar changed the title splitcidr initial commit splitcidr Sep 21, 2022
@rm-Umar rm-Umar marked this pull request as ready for review September 21, 2022 09:47
@rm-Umar rm-Umar requested a review from UmanShahzad September 21, 2022 09:58
UmanShahzad
UmanShahzad suggested changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@UmanShahzad UmanShahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add to:

  • scripts/fmt.sh
  • scripts/lint.sh
  • .gitignore

Also I guess this doesn't yet solve the v6 split?

ipinfo/cmd_splitcidr.go Outdated Show resolved Hide resolved
ipinfo/cmd_splitcidr.go Show resolved Hide resolved
ipinfo/main.go Show resolved Hide resolved
splitcidr/main.go Outdated Show resolved Hide resolved
splitcidr/main.go Show resolved Hide resolved
lib/cmd_splitcidr.go Outdated Show resolved Hide resolved
lib/cmd_splitcidr.go Show resolved Hide resolved
lib/ip_subnet.go Outdated Show resolved Hide resolved
lib/ip_subnet.go Show resolved Hide resolved
lib/ip_subnet.go Show resolved Hide resolved
@rm-Umar
Copy link
Contributor Author

rm-Umar commented Sep 28, 2022

Need to add to:

  • scripts/fmt.sh
  • scripts/lint.sh
  • .gitignore

Also I guess this doesn't yet solve the v6 split?

Yes it's only for v4 for now.

@rm-Umar rm-Umar requested a review from UmanShahzad September 28, 2022 09:01
UmanShahzad
UmanShahzad suggested changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@UmanShahzad UmanShahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPv6 doesn't seem to be working. I did ::/127 128 and it panics.

@rm-Umar
Copy link
Contributor Author

rm-Umar commented Sep 28, 2022

IPv6 doesn't seem to be working. I did ::/127 128 and it panics.

should work now, there was a bug in copying big int to []byte

@UmanShahzad
Copy link
Contributor

@rm-Umar great work!

@UmanShahzad UmanShahzad merged commit f5bc3be into master Sep 28, 2022
@UmanShahzad UmanShahzad deleted the umar/splitcidr branch September 28, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UmanShahzad UmanShahzad UmanShahzad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IP split CIDR tool
2 participants
@rm-Umar @UmanShahzad