fix csv format #118
Merged
fix csv format #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm-Umar
force-pushed
the
umar/fix-csv-format
branch
from
7ad609e to
ce140d8
Compare
|
Address is the only field that'll break csv froamt, so we can explicitly quote address field to counter this issue |
UmanShahzad
suggested changes
Aug 10, 2022
|
Is this WIP or actually ready @rm-Umar ? |
|
As I expected the CSV writer adds a newline at the end on each write it does, so we have all kinds of weird scenarios happening: $ ./build/ipinfo bulk --csv -f asn 1.1.1.1 2.2.2.2
ip,asn_id,asn_name,asn_domain,asn_route,asn_type
1.1.1.1,AS13335,"Cloudflare, Inc.",cloudflare.com,1.1.1.0/24,hosting
2.2.2.2,AS3215,Orange S.A.,orange.com,2.2.0.0/16,isp
$ ./build/ipinfo bulk --csv -f asn,asn 1.1.1.1 2.2.2.2
ip,asn_id,asn_name,asn_domain,asn_route,asn_type,asn_id,asn_name,asn_domain,asn_route,asn_type
1.1.1.1,AS13335,"Cloudflare, Inc.",cloudflare.com,1.1.1.0/24,hosting
,AS13335,"Cloudflare, Inc.",cloudflare.com,1.1.1.0/24,hosting
2.2.2.2,AS3215,Orange S.A.,orange.com,2.2.0.0/16,isp
,AS3215,Orange S.A.,orange.com,2.2.0.0/16,isp
|
It's still in progress I'll mark it ready when it's ready. |
|
Ah okay. Got pinged for review so wasn't sure 😄 |
Now it's ready to review. |
|
Will release it tomorrow or the day after hopefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #85