Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPIP-428: Allowing V2-Only Records in IPNS #428

Merged
merged 8 commits into from
Sep 12, 2023
Merged

IPIP-428: Allowing V2-Only Records in IPNS #428

merged 8 commits into from
Sep 12, 2023

Conversation

lidel
Copy link
Member

@lidel lidel commented Jul 25, 2023

Closes #376

This IPIP introduces support for creation and validation of compact, V2-only IPNS Records.

initial draft for early feedback
@lidel lidel changed the title ipip-428: Allowing V2-Only Records in IPNS IPIP-428: Allowing V2-Only Records in IPNS Jul 25, 2023
src/ipips/ipip-0428.md Outdated Show resolved Hide resolved
src/ipips/ipip-0428.md Outdated Show resolved Hide resolved
src/ipips/ipip-0428.md Outdated Show resolved Hide resolved
src/ipips/ipip-0428.md Outdated Show resolved Hide resolved
src/ipips/ipip-0428.md Outdated Show resolved Hide resolved
@@ -259,9 +285,91 @@ Finally, the network nodes may also republish their records, so that the records

### Record Creation

IPNS record MUST be serialized as `IpnsEntry` protobuf, and `IpnsEntry.data` MUST be signed using the private key.
IPNS record MUST be serialized as `IpnsEntry` protobuf, and `IpnsEntry.data`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could rename IpnsEntry to IpnsRecord?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not against it, but want to limit what we change in IPIP to minimum, so it is easier to review.
Let's make a separate editorial PR after this IPIP lands.

Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the updates conform to the changes we've made to Boxo in ipfs/boxo#339

@lidel lidel marked this pull request as ready for review August 17, 2023 14:10
@lidel lidel requested a review from a team as a code owner August 17, 2023 14:10
Copy link
Member Author

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/ipips/ipip-0428.md Outdated Show resolved Hide resolved
Copy link
Member Author

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied final editorials and included test vectors from ipfs/gateway-conformance#157
Flagged during IPFS Implementers call multiple times, no concerns were raised about ratification.

Merging to ensure https://specs.ipfs.tech/ipns/ipns-record/ is up-to-date and includes test vectors.

@lidel lidel merged commit 4ba553f into main Sep 12, 2023
2 checks passed
@lidel lidel deleted the ipns-v2-only branch September 12, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ratified
Archived in project
Development

Successfully merging this pull request may close these issues.

IPNS: allow lean V2-only records
2 participants