Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document CBOR in /reframe?q= #333

Closed
wants to merge 1 commit into from

Conversation

lidel
Copy link
Member

@lidel lidel commented Oct 14, 2022

Due to miscommunication, go-delegated-routing v0.6.0 uses DAG-CBOR in ?q (and not DAG-JSON, like we expected) 🙈
Details: ipld/edelweiss#61

This PR updates the spec to describe the current pre-alpha implementation that shipped with Kubo 0.16

TODO: make decision if we change spec, or fix implementation

👉 If we are not planning to surgically fix this SOON (as proposed in ipld/edelweiss#61) I suggest we update specs to reflect implementation

Due to miscommunication, go-delegated-routing v0.6.0
 uses CBOR  in `?q` – this updates the spec to describe current pre-alpha implementation.
@lidel lidel marked this pull request as ready for review October 14, 2022 17:45
@lidel lidel marked this pull request as draft October 14, 2022 18:27
Copy link
Contributor

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does appear to reflect reality

maybe worth a comment about spaces being url encoded to '+'s and not being percent encoded? (although it's probably safer to percent encode them first and the decoder will take that as well)

@lidel
Copy link
Member Author

lidel commented Oct 20, 2022

This turned out to be a big time sink – existing wire format and implementation has other issues, such as buffering streaming responses due to Etag generation.

I am closing this – if we want to fix Reframe we should stop bending backward and changing specs to fix broken implementation – only way forward for Reframe over HTTP is to implement #327

@lidel lidel closed this Oct 20, 2022
@lidel lidel deleted the docs/aligh-with-go-delegated-routing-v0.6.0 branch October 20, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants