docs: ipns #184
Merged
docs: ipns #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Aug 29, 2018
A working version of **IPNS working locally** is here! 🚀 😎 💪 Steps: - [x] Create a new repo (**js-ipns**) like it was made with go in the last week ([go-ipns](https://github.com/ipfs/go-ipns)) and port the related code from this PR to there - [x] Resolve IPNS names in publish, in order to verify if they exist (as it is being done for regular files) before being published - [x] Handle remaining parameters in publish and resolve (except ttl). - [x] Test interface core spec [interface-ipfs-core#327](ipfs-inactive/interface-js-ipfs-core#327) - [x] Test interoperability with go. [interop#26](ipfs/interop#26) - [x] Integrate logging - [x] Write unit tests - [x] Add support for the lifetime with nanoseconds precision - [x] Add Cache - [x] Add initializeKeyspace - [x] Republish Some notes, regarding the previous steps: - There is an optional parameter not implemented in this PR, which is `ttl`, since it is still experimental, we can add it in a separate PR. Finally, thanks @Stebalien for your help and time answering all my questions regarding the IPNS implementation in GO. Moreover, since there are no specs, and not that much documentation, I have been writing a document with all the IPNS workflow. It is a WIP by now, but it is currently available [here](ipfs/specs#184). Related PRs: - [x] [js-ipns#4](ipfs/js-ipns#4) - [x] [js-ipfs-repo#173](ipfs/js-ipfs-repo#173) - [x] [js-ipfs#1496](#1496) - [x] [interface-ipfs-core#327](ipfs-inactive/interface-js-ipfs-core#327) - [x] enable `interface-ipfs-core` tests for IPNS in `js-ipfs`
vasco-santos
force-pushed
the
docs/ipns
branch
2 times, most recently
from
df8f212
to
a8eb579
Compare
|
cc @Stebalien |
ghost
assigned
|
This is currently blocked on: ipfs/interop#39#issuecomment-434822613 |
vasco-santos
force-pushed
the
docs/ipns
branch
from
a8eb579
to
52937f0
Compare
|
Spec updated with the interop changes |
Stebalien
reviewed
Dec 17, 2018
vasco-santos
force-pushed
the
docs/ipns
branch
2 times, most recently
from
d50c138
to
016fd6e
Compare
vasco-santos
force-pushed
the
docs/ipns
branch
from
016fd6e
to
4cbb006
Compare
|
Thanks for the review @Stebalien I believe that I have taken all your feedback into account with the last commit. I changed the |
Stebalien
approved these changes
Dec 27, 2018
Co-Authored-By: vasco-santos <[email protected]>
Co-Authored-By: vasco-santos <[email protected]>
vasco-santos
force-pushed
the
docs/ipns
branch
from
698dd2e
to
8bb2ed1
Compare
|
Thanks for the last pass @Stebalien ! I have fixed your last comments. I totally agree that it could use a pass by a technical writer. We should probably try to have one in the future to look at all our specs/documentation. |
|
LGTM. It looks ready to me but I'll let you merge it when you're ready. |
|
It is good to go! However, I do not have write access to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs for IPNS implementation