Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opt-in protocol and address filtering (IPIP-484) #82

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Sep 13, 2024

What's in this PR

Blocked by

Related Specs

ipfs/specs#484

@lidel lidel changed the title Add protocol and address filtering (IPIP-484) feat: opt-in protocol and address filtering (IPIP-484) Sep 26, 2024
@2color 2color marked this pull request as ready for review October 7, 2024 09:38
CHANGELOG.md Outdated Show resolved Hide resolved
@2color
Copy link
Member Author

2color commented Oct 9, 2024

For now I've upgraded only to go-libp2p v0.36.4 because v0.36.5 leads to go: upgraded go 1.22 => 1.22.0 which breaks the build.

This comment was marked as outdated.

Copy link

Suggested version: 0.5.0

Comparing to: v0.4.2 (diff)

Changes in configuration file(s):

(empty)

gorelease says:

# summary
Suggested version: v0.4.3

gocompat says:

HEAD is now at 02b8190 fix: go-libp2p-kad-dht v0.26.1 (#80)
Previous HEAD position was 02b8190 fix: go-libp2p-kad-dht v0.26.1 (#80)
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. (the go-libp2p v0.36.5 worked fine after i removed toolchain, so bumped it as well)
feel free to merge + deploy to prod

@2color 2color merged commit 338d6ba into main Oct 10, 2024
9 checks passed
@lidel lidel deleted the add-protocol-filtering branch October 10, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants