-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add webtransport as an optin transport #9293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not merge for now, I got nil deref panics quickly (once when dialling crashed both nodes, once when quiting crashed the remote node). |
Jorropo
force-pushed
the
webtransport
branch
from
September 22, 2022 08:20
08b0401
to
0f90e59
Compare
Jorropo
commented
Sep 22, 2022
Closed
ajnavarro
reviewed
Sep 22, 2022
ajnavarro
reviewed
Sep 22, 2022
Jorropo
force-pushed
the
webtransport
branch
from
September 23, 2022 17:37
0f90e59
to
8e802c9
Compare
Jorropo
force-pushed
the
webtransport
branch
from
September 23, 2022 17:51
8e802c9
to
8baec10
Compare
marten-seemann
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @Jorropo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO before merge:
TODO (doable after merge but must be done before release (RC excluded)):
config.md
and in the changelog)