-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gateway support for tar.gz #9034
Conversation
3e895e2
to
d82f396
Compare
License: MIT Signed-off-by: Henrique Dias <[email protected]>
82c2f21
to
5b270b2
Compare
I don't like that such CPU hogging feature (file compression) is accessible on the gateway using the default config. I would like this more if it was dynamically scaling the compression level based on the CPU load. |
Also if someone cared about that, I think they are running a gateway seriously, and if they are, they are using a reverse proxy for TLS. Can't they just configure the reverse proxy to handle compression ? |
I don't really mind if it's there but I think it should be optional. (I guess that a comment for the spec PR.) Also I think it should be generalised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's park this until we agree on specs in ipfs/specs#288.
DoS concerns make this a good candidate for testing RFC process. 🥳
@hacdias when writing RFC for that PR, it would be useful to mention the concerns around .tar.gz
variant in "Alternatives" and "Security" sections.
My hot take is that .tar
from #9029 is fine, but .tar.gz
from this PR comes with too much risk, but let's discuss that in ipfs/specs around RFC. 🙏
d82f396
to
a3b08be
Compare
Closing as we decided to only do TAR (compression can happen at transport layer). |
Built on top of #9029 and adds
tar.gz
format.The official MIME Type for
.gz
isapplication/gzip
. However, that makes it harder for us to distinguish what type of file it is. Therefore, I appended+gzip
to the MIME Type of the TAR.License: MIT
Signed-off-by: Henrique Dias [email protected]