chore: verify checksums during dist.ipfs.io sync #8587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lidel @aschmahmann should we use this PR for good measure? Verifying the checksums prevents us from accepting a corrupt file coming from 'ipfs get'. I imagine the chances of this are low. Happy to go either way. (Otherwise, it looks like @lidel's PR solves the actual issue we had.) |
lidel
changed the title
also, ignore path from sha512sum output, which sometimes has absolute path on dist website
lidel
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
lgtm, thank you @petar, this makes things more robust
- I simplified it a bit by removing maps and switching to Sets (funny thing: in JS a Set preserves the insertion order, so can act as replacement for lists)
- Applied to libp2p-relay-daemon repo already, and tested in https://github.com/libp2p/go-libp2p-relay-daemon/releases/tag/v0.1.0 – worked as expected, but would be good to get another 👍 before merging
|
@lidel Thanks for testing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.