buffer the entire dag before export #8502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
an alternative to this that doesn't buffer the entire dag is #8503. This PR should probably be closed since I suspect buffering the whole dag is not a tenable solution, but I will leave it open for now as an option |
|
just for linkage, the context for this is #8323 |
|
As you mentioned buffering seems pretty bad for performance and usability here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will buffer the entire dag.
I don't think this is the best option, but the idea here is to buffer the entire dag so errors can be detected, if an error is detected, the dag won't be exported.
The downside is obvious, that the entire dag is buffered.