Add 0.4.21 CHANGELOG #6372

Kubuxu · 2019-05-23T15:43:07Z

WIP. Please either add or mention in comments what should be featured.

Kubuxu · 2019-05-23T15:43:33Z

Should we clean up dependency changelog?

Stebalien · 2019-05-23T16:24:07Z

Should we clean up dependency changelog?

Probably. Really, I wouldn't print out the version changes, that doesn't say much. Instead, I'd print the actual change log (commit messages) from each dep in one of our orgs (multiformats, ipfs, ipld, libp2p, etc.).

Going through that also helps flesh out the features/changes.

Kubuxu · 2019-05-23T20:13:13Z

I can write that, but this will be even more noise.
We for sure don't want to include git changelogs for the whole libp2p ecosystem in our changelog.

djdv · 2019-05-23T20:36:40Z

minor change (may or may not be worth mentioning) in: #6277

We're now base64 encoding values returned by dht get when encoding them into JSON

Previously these where byte slices directly cast as strings, which could produce invalid values/output.
Now the binary values are encoded.

Stebalien · 2019-05-23T21:08:32Z

We for sure don't want to include git changelogs for the whole libp2p ecosystem in our changelog.

It's actually quite useful as we benefit from all of those changes. We don't have to include them but I wouldn't include the version changes regardless.

Take a look at the changelogs from the last few releases.

minor change (may or may not be worth mentioning) in: #6277

We should definitely mention that as a breaking change.

momack2 · 2019-05-24T05:32:01Z

CHANGELOG.md

+go versions during builds.
+
+
+(please point out what should be featured, doesn't have to be go-ipfs).


Should we pull the list of contributors like Alan did in the most recent js-ipfs release? https://github.com/ipfs/js-ipfs/releases/tag/v0.36.0

CHANGELOG.md

momack2 · 2019-05-24T05:33:50Z

CHANGELOG.md

+  - reprovider: Use goprocess ([ipfs/go-ipfs#6248](https://github.com/ipfs/go-ipfs/pull/6248))
+  -  add: Fix adding multiple files ([ipfs/go-ipfs#6255](https://github.com/ipfs/go-ipfs/pull/6255))
+  - dep: update libp2p, dht, peerstore, swarm, secio ([ipfs/go-ipfs#6257](https://github.com/ipfs/go-ipfs/pull/6257))
+  - Fix AutoNAT service for private network ([ipfs/go-ipfs#6251](https://github.com/ipfs/go-ipfs/pull/6251))


is this notable?

It's unlikely to affect many users.

momack2 · 2019-05-24T05:34:45Z

CHANGELOG.md

+  - docs: fix Routing section ([ipfs/go-ipfs#6309](https://github.com/ipfs/go-ipfs/pull/6309))
+  - fix(Dockerfile): Allow ipfs mount in Docker container ([ipfs/go-ipfs#5560](https://github.com/ipfs/go-ipfs/pull/5560))
+  - test(coreapi): use a thread-safe datastore everywhere ([ipfs/go-ipfs#6222](https://github.com/ipfs/go-ipfs/pull/6222))
+  - ping: fix a bunch of issues ([ipfs/go-ipfs#6312](https://github.com/ipfs/go-ipfs/pull/6312))


any of these worth calling out?

momack2 · 2019-05-24T05:35:24Z

CHANGELOG.md

+  - doc: remove out of date documentation ([ipfs/go-ipfs#6345](https://github.com/ipfs/go-ipfs/pull/6345))
+  - core: Use correct default for connmgr lowWater ([ipfs/go-ipfs#6352](https://github.com/ipfs/go-ipfs/pull/6352))
+  - fix vendoring dependencies when building the source tarball ([ipfs/go-ipfs#6349](https://github.com/ipfs/go-ipfs/pull/6349))
+  - feat: improve errors when a path fails to parse ([ipfs/go-ipfs#6346](https://github.com/ipfs/go-ipfs/pull/6346))


yay for better errors?

WIP. Please either add or mention in comments what should be featured. License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

Co-Authored-By: MollyM <[email protected]>

Stebalien · 2019-05-28T11:23:29Z

I've filled out the release notes and added a recursive changelog.

Stebalien · 2019-05-28T11:23:44Z

cc @ipfs/wg-go-core please review.

CHANGELOG.md

eingenito · 2019-05-28T17:07:36Z

@Stebalien Should we mention the intention to default to dhtclient routing in a future release?

Stebalien · 2019-05-28T17:08:51Z

@Stebalien Should we mention the intention to default to dhtclient routing in a future release?

Thanks for the reminder. Yes!

Co-Authored-By: Dominic Della Valle <[email protected]>

michaelavila · 2019-05-28T17:20:02Z

CHANGELOG.md

+
+#### Human Readable Numbers
+
+The `ipfs bitswap stat` and and `ipfs object stat` commands now support a


Suggested change

The `ipfs bitswap stat` and and `ipfs object stat` commands now support a

The `ipfs bitswap stat` and `ipfs object stat` commands now support a

Stebalien · 2019-05-28T17:22:05Z

@Stebalien Should we mention the intention to default to dhtclient routing in a future release?

Ugh. It looks like configs specify "dht" by default, not "". We'd have to reinterpret that to change the default for existing nodes.

We can still make it the default for future nodes but that doesn't really require an announcement this release.

CHANGELOG.md

Co-Authored-By: Michael Avila <[email protected]>

Stebalien · 2019-05-29T22:23:37Z

We can clean these up post-release if necessary. Let's get this out the door.

Kubuxu mentioned this pull request May 23, 2019

Release v0.4.21 #6305

Closed

momack2 reviewed May 24, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

momack2 reviewed May 24, 2019

View reviewed changes

Kubuxu and others added 5 commits May 28, 2019 04:05

Add 0.4.21 CHANGELOG

2c8fa10

WIP. Please either add or mention in comments what should be featured. License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

Update CHANGELOG.md

f8914f4

Co-Authored-By: MollyM <[email protected]>

misc: update mkreleaselog to build a recursive changelog

8fb4e92

CHANGELOG: recursive changes

0845786

CHANGELOG flesh out for 0.4.21-RC3

3945560

Stebalien force-pushed the feat/0.4.21-releaselog branch from 4dedc80 to 3945560 Compare May 28, 2019 11:21

djdv reviewed May 28, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG: apply CR

8e9adf3

Co-Authored-By: Dominic Della Valle <[email protected]>

michaelavila reviewed May 28, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

michaelavila reviewed May 28, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Stebalien and others added 2 commits May 28, 2019 10:36

CHANGELOG: fix typos

d53d73b

Co-Authored-By: Michael Avila <[email protected]>

CHANGELOG: finish todos

655b03c

Stebalien merged commit 6cd273f into master May 29, 2019

Stebalien deleted the feat/0.4.21-releaselog branch May 29, 2019 22:23

Stebalien restored the feat/0.4.21-releaselog branch May 30, 2019 22:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 0.4.21 CHANGELOG #6372

Add 0.4.21 CHANGELOG #6372

Kubuxu commented May 23, 2019

Kubuxu commented May 23, 2019

Stebalien commented May 23, 2019

Kubuxu commented May 23, 2019

djdv commented May 23, 2019 •

edited

Loading

Stebalien commented May 23, 2019

momack2 May 24, 2019

momack2 May 24, 2019

Stebalien May 28, 2019

momack2 May 24, 2019

Stebalien May 28, 2019

momack2 May 24, 2019

Stebalien May 28, 2019

Stebalien commented May 28, 2019

Stebalien commented May 28, 2019

eingenito commented May 28, 2019

Stebalien commented May 28, 2019

michaelavila May 28, 2019

Stebalien commented May 28, 2019

Stebalien commented May 29, 2019

		go versions during builds.


		(please point out what should be featured, doesn't have to be go-ipfs).


		#### Human Readable Numbers

		The `ipfs bitswap stat` and and `ipfs object stat` commands now support a

	The `ipfs bitswap stat` and and `ipfs object stat` commands now support a
	The `ipfs bitswap stat` and `ipfs object stat` commands now support a

Add 0.4.21 CHANGELOG #6372

Add 0.4.21 CHANGELOG #6372

Conversation

Kubuxu commented May 23, 2019

Kubuxu commented May 23, 2019

Stebalien commented May 23, 2019

Kubuxu commented May 23, 2019

djdv commented May 23, 2019 • edited Loading

Stebalien commented May 23, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Stebalien commented May 28, 2019

Stebalien commented May 28, 2019

eingenito commented May 28, 2019

Stebalien commented May 28, 2019

Choose a reason for hiding this comment

Stebalien commented May 28, 2019

Stebalien commented May 29, 2019

djdv commented May 23, 2019 •

edited

Loading