Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider queue: don't repeatedly retry the same item if we fail #6187

Merged
merged 1 commit into from
Apr 5, 2019
Merged

provider queue: don't repeatedly retry the same item if we fail #6187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions provider/queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,14 @@ func (q *Queue) nextEntry() (datastore.Key, cid.Cid) {
key := q.queueKey(q.head)
value, err := q.ds.Get(key)

if err == datastore.ErrNotFound {
log.Warningf("Error missing entry in queue: %s", key)
if err != nil {
if err == datastore.ErrNotFound {
log.Warningf("Error missing entry in queue: %s", key)
} else {
log.Errorf("Error fetching from queue: %s", err)
}
q.head++ // move on
continue
} else if err != nil {
log.Warningf("Error fetching from queue: %s", err)
continue
}

c, err := cid.Parse(value)
Expand Down