chore: fix a bunch of issues caught by golangci-lint #6140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Stebalien
commented
Mar 27, 2019
core/coreunix/add.go
Outdated
| if err == nil { | ||
| err = adder.bufferedDS.Commit() | ||
| } | ||
| }() |
There was a problem hiding this comment.
Cause of #6139 (comment). We're ignoring the add error for small files.
There was a problem hiding this comment.
This will need a named err return value or something. Right now it references the first declared err and doesn't intercept any of the ones down below.
|
I got an unrelated error that looks like a leveldb bug. |
|
Codeclimate has one more new issue for you. |
Stebalien
force-pushed
the
fix/golangci-lint
branch
from
5f12c58
to
dbd7185
Compare
Stebalien
added a commit
that referenced
this pull request
Mar 28, 2019
see: #6140 (comment) License: MIT Signed-off-by: Steven Allen <[email protected]>
Merged
Most of these are probably harmless but a few looked like they might actually be bugs. Most of them are just faulty tests. License: MIT Signed-off-by: Steven Allen <[email protected]>
License: MIT Signed-off-by: Steven Allen <[email protected]>
1. Yes, I like my symmetry. 2. No, we don't want to stash the private key if we fail to put it in the peerstore. License: MIT Signed-off-by: Steven Allen <[email protected]>
Stebalien
force-pushed
the
fix/golangci-lint
branch
from
8eb7321
to
5ee455b
Compare
|
I've moved the add fix to #6156 so we can merge it sooner. |
|
@Kubuxu can I get a signoff? |
Kubuxu
approved these changes
Mar 29, 2019
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
chore: fix a bunch of issues caught by golangci-lint This commit was moved from ipfs/kubo@fd15c62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these are probably harmless but a few looked like they might actually be bugs. Most of them are just faulty tests.
Why? Well, I thought "let me just try running this linter..." and then spent way more time than I should have on this.