Fuse fixes #6135
Merged
Fuse fixes #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anacrolix
commented
Mar 27, 2019
anacrolix
commented
- Skip errors due to fuse missing on OSX
- Downgrade bootstrap node error: It's very noisy in the test logs, and probably indicates user error (which may be a warning), rather than an actual, unexpected error.
- Fix automatic installation of go-fuse-version with go modules
- Misc uses of testing.T.Helper
It's very noisy in the test logs, and probably indicates user error (which may be a warning), rather than an actual, unexpected error.
|
I thought the GitCop stuff was removed? |
We were waiting on final instructions from legal. |
djdv
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
This seems sensible to me.
The only concern I had was that it's assumed module support is enabled, rather than checking for it and falling back to get. But that doesn't actually seem necessary to handle given the additional complexity involved in checking the go version, the env, etc.
In the (near) future I'm going to look into integrating this check inside of go-ipfs when on OS X rather than executing external commands to achieve this.
|
What's the plan now? Should I rebase with the sign-offs, or can you just merge as is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.