Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command repo stat: improve human flag behavior #6106

Merged

Conversation

reinerRubin
Copy link
Contributor

Now use go-humanize when --human flag is provided.

#6103

Now use go-humanize

License: MIT
Signed-off-by: Georgij Tolstov <[email protected]>
@reinerRubin
Copy link
Contributor Author

@Kubuxu, could you help me with the "codecov/patch" result? Should I add more tests? To test/sharness/t0080-repo.sh or somewhere else?

@Stebalien Stebalien merged commit ee33606 into ipfs:master Mar 20, 2019
@Stebalien
Copy link
Member

@reinerRubin we should add tests, want to take on #6110?

(didn't want to block this on not testing something we've never tested)

@Stebalien
Copy link
Member

And thanks for the quick fix!

@reinerRubin
Copy link
Contributor Author

@reinerRubin we should add tests, want to take on #6110?

@Stebalien, yeah why not. I want to get acquainted with the project. So not complicated tests would be great.

@Stebalien
Copy link
Member

cc @ipfs/wg-js-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants