add support for IPLD over IPNS #5602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not *perfect* but at least `ipfs name resolve` can resolve IPNS records pointing to IPLD paths. `ipfs dag get /ipns` still doesn't work but we can *make* it work once we switch to CoreAPI. License: MIT Signed-off-by: Steven Allen <[email protected]>
ghost
assigned
Stebalien
commented
Oct 16, 2018
| @@ -25,15 +25,6 @@ func resolve(ctx context.Context, r resolver, name string, options *opts.Resolve | |||
| } | |||
| log.Debugf("resolved %s to %s", name, p.String()) | |||
|
|
|||
| if strings.HasPrefix(p.String(), "/ipfs/") { | |||
There was a problem hiding this comment.
I've changed this check to "is not /ipns/". That way, we continue resolving until we can no longer resolve.
Stebalien
commented
Oct 16, 2018
| if !strings.HasPrefix(name, "/") { | ||
| return path.ParsePath("/ipfs/" + name) | ||
| } | ||
| // TODO: Forbid this case. |
There was a problem hiding this comment.
Can't do this now but I'd rather require complete paths (forbidding a raw "Qm..."). However, that'll be a harder change.
|
This code is mostly rewritten in #5404. We should also consider dropping the |
Stebalien
added
the
status/blocked
|
Let's block this on that PR then. |
|
Fixed in #5404. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not perfect but at least
ipfs name resolvecan resolve IPNS records pointing to IPLD paths.ipfs dag get /ipnsstill doesn't work but we can make it work once we switch to CoreAPI.I thought this would be difficult, apparently not...