-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add quieter option to name publish #5494
Conversation
Sorry, I'm at a loss, could anyone provide any pointers about what might be wrong here? The Travis CI logs show at the end:
|
Looking few lines above:
Possibly a random travis glitch, re-triggered |
Yup. https://www.traviscistatus.com/:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, a sharness test would be nice though (probably in t100-name.sh
)
Added a quieter/Q option to 'name publish' that, consistent with 'add', only outputs the value that was published. License: MIT Signed-off-by: Rob Deutsch <[email protected]>
Thanks for that! Tests added, and the code was amended to fix an issue that the test identified! |
Note: I would thoroughly appreciate if someone could do a real live test on their machine. My IPFS node is a tad broken at the moment.
Motivation: This post on reddit.
Details:
Added a quieter/Q option to 'name publish' that, consistent with 'add', only outputs the value that was published.