Fixes nc on macOS not closing socket when the stdin sends EOF #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `-d` option that is supported both by BSD and GNU nc. License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
|
The test won't pass until it is killed manually and all PRs use this as a base. |
|
This LGTM, at some point @jbenet will find time to restart the cjdns daemon on the OSX runner and we can move forward with this. I really need to figure out how to make a startup script for osx |
|
@whyrusleeping this could be merged before that as any PR that has base older than this will cause the hang again. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
-doption that is supported both by BSD and GNU nc.Resolves: #3496
License: MIT
Signed-off-by: Jakub Sztandera [email protected]