namesys: add entry to DHT cache after publish #3501
Conversation
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feat/namesys/publish-cache
branch
from
0b9a8b5
to
9fe9d9e
Compare
|
@whyrusleeping it isn't supper nice solution but without some refactor there isn't anything much better might be done. |
| path "github.com/ipfs/go-ipfs/path" | ||
|
|
There was a problem hiding this comment.
| if err != nil { | ||
| return err | ||
| } | ||
| ns.addToDHTCache(name, value, time.Now().Add(time.Hour*24)) |
There was a problem hiding this comment.
lets pull this magic number out and justify it
There was a problem hiding this comment.
It is the same as in publisher.go, should I add comment for it?
There was a problem hiding this comment.
Or extract it from publisher?
There was a problem hiding this comment.
I'd extract it from both, and give it a small comment
There was a problem hiding this comment.
Lets just call it DefaultRecordTTL (i had to go look at it again to remember what exactly this was)
There was a problem hiding this comment.
Hah, gave it the same name without reading this. <3
| var err error | ||
| value, err = path.ParsePath(value.String()) | ||
| if err != nil { | ||
| log.Error("could not parse path") |
There was a problem hiding this comment.
maybe add the actual error to this? might aid in debugging random error messages
There was a problem hiding this comment.
This is only cache, I didn't want it to fail the publish (as it was already published and we can't revert it).
| return ns.publishers["/ipns/"].PublishWithEOL(ctx, name, val, eol) | ||
| func (ns *mpns) addToDHTCache(key ci.PrivKey, value path.Path, eol time.Time) { | ||
| var err error | ||
| value, err = path.ParsePath(value.String()) |
There was a problem hiding this comment.
wait, why are we converting the thing to a string, then back to a path?
There was a problem hiding this comment.
Yes as the publisher can publish hash only but resolver will sanitize this value to be /ipfs/CID which is what ParsePath does.
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
|
Yes, they are separate modules that don't know about each others existence. |
|
Is this problem IPNS specific? I love how this PR solves the problem in hand without changing much code, but I see it as a temporary fix that will need to be removed after the real issue has been addressed. The caching could be moved into the DHT-based IPRS implementation, so the /pk/ namespace could benefit from it as well. Namesys uses both. I am not aware of other IPRS namespaces, but probably it would apply to any record types. |
|
IPRS doesn't exist yet, I like to call IPNS a huge PoC that mutable data is possible even though the content is immutable. Yes, after IPRS is designed, speced out, and implemented it can be moved into one place with infrastructure that will include caching of self published record in its design. When code of namesys was written it wasn't a feature that was taken into account. |
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
| if err != nil { | ||
| return err | ||
| } | ||
| ns.addToDHTCache(name, value, time.Now().Add(DefaultRecortTTL)) |
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
ghost
mentioned this pull request
|
I am still experiencing slow ipns resolving. For a minute after I publish it will be fast, but then it takes a very long time. |
Resolves #2078
License: MIT
Signed-off-by: Jakub Sztandera [email protected]