-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Bash complete script #3377
Conversation
Some minor bug still exist but not breaking. Everything is marked with "TODO" inline the script. License: MIT Signed-off-by: Elias Gabrielsson <[email protected]>
Replacing old pull request. @Kubuxu |
Hmm, zsh has bash completion compat, which means that I can give it actual use test. I will use it for 1-2 days and get back to you. Thanks again. |
Looks like it doesn't work well for complex completions so I will just run it in bash and test out. |
LGTM, only thing that I observed is that it doesn't support short options Thank you very much. @whyrusleeping good for merge. |
I have intentionally not implemented short option. It's not a big deal to implement if its needed. |
Nah, I think in the bash's completion method it might cause more confusion than good. |
Alright cool, will be good to finally have this in. |
Under the development of the complete-script I have wonder how the script could be installed in an easy fashion way.
The What do you think? |
Usually it is package mangers that do this and I think it is good enough. |
Some minor bug still exist but not breaking.
Everything is marked with "TODO" inline the script.
License: MIT
Signed-off-by: Elias Gabrielsson [email protected]