Create a FilestoreNode object to carry PosInfo #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2016
|
This includes #3307. I notice sharding is listed as a milestone for 2016-11-07 (in ipfs/team-mgmt#224). This is likely to conflict with any sharing changes so it will make my life easier if this gets merged before any sharding work is done. Thanks. |
kevina
force-pushed
the
kevina/posinfo-2
branch
from
d5955ce
to
c67df22
Compare
When doing a filestore add, we wrap whatever nodes we create in a FilestoreNode object and add the PosInfo to it so that the filestore will be able to extract information as needed. Edited by whyrusleeping License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
kevina
force-pushed
the
kevina/posinfo-2
branch
from
c67df22
to
65ffff2
Compare
kevina
added
status/ready
|
@whyrusleeping I just rebased this and it should be good to go assuming the tests pass. |
|
Ship it! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2634.