-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a very basic many to many pubsub #3202
Conversation
Pubsub subsub pubsub hubbub dubtub? Wub. Wub. Pubsub. | ||
Nubs, Tubs, Wubs, pub Dubs. Pub subdub pub pub sub nub. | ||
|
||
ipfs pubsub pub "pubsub hubbub" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, forgot the topic flag here
Voting for the name, thumbs up comments to vote: |
OPTION: floodsub |
OPTION: hubbub |
OPTION: libp2p-flooding-based-publish-subscribe-system |
OPTION: hub |
4180ec9
to
86e7f61
Compare
pub. Pubsub subsub subpubsub hubbub pub sub grub subhubbub. | ||
Pubsubs sub hubbub sub tub, dub dub dub wub wub wub wub wub. Pubsub. | ||
Pubsub subsub pubsub hubbub dubtub? Wub. Wub. Pubsub. | ||
Nubs, Tubs, Wubs, pub Dubs. Pub subdub pub pub sub nub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix desc. Add a description, denoting experimental
@jbenet should we have the command set to be enabled by a config option? Or do you think that just stating in each commands helptext that its experimental is enough? |
Hmmm. yeah i'd hide them unless either:
|
a flag would be better because a config option is hard to remove once it's there. |
What about "subhub"? |
it works 👍 |
cf6fcf2
to
db986da
Compare
Rebased on top of new libp2p changes that let us interop with js-ipfs. Also cleaned up a bunch of the code |
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
9fdc202
to
91db6f3
Compare
Alright, merging this in. Its experimental, definitely subject to change, but man is it fun to play with. |
@whyrusleeping Sweet! Are there any Go code examples using this functionality that I can check out? |
Not yet! It's on my to-do list :) On Sat, Oct 1, 2016, 19:16 Steve Phillips [email protected] wrote:
|
Also some notes on performance. I just stumbled upon this (had no idea!), and am really interested. With that said, i've got no idea how well it scales, very broad performance characteristics, etc. A high level paper would be very appreciated! Excellent work 💯 ! |
@whyrusleeping That is amazing, are you still planning to do any examples? |
Add a very basic many to many pubsub This commit was moved from ipfs/kubo@e1c40df
This is experimental, but will very likely be merged into master.
For more information on the general protocol, take a look at: https://github.com/libp2p/pubsub-notes
and for the implementation being used here: https://github.com/whyrusleeping/go-floodsub