Enhance tests for files API root best-effort pin. #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet, LGTM! @jbenet wanna take a look here? |
whyrusleeping
added
need/review
|
|
||
| test_expect_success "add incomplete directory and make sure gc is okay" ' | ||
| ipfs files cp /ipfs/$MYDIR_HASH /mydir && | ||
| ipfs repo gc |
There was a problem hiding this comment.
I would do ipfs cat $HELLO_HASH here too, just to be sure the thing is really gone and stays gone.
|
Some comments above |
License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
kevina
force-pushed
the
kevina/more3138tests
branch
from
99cbe12
to
6e4f3ac
Compare
|
@jbenet thanks, I just amended my commit with your corrections. Sorry about the missing "&&", I actually meant to review this one more time before removing the "in progress" label. |
|
This LGTM. I would change a few stylistic things (like redirect the 'ipfs cat' calls either to dev/null, or check their output explicitly). But thats not a huge deal, and isnt really relevant to what we're testing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Kevin Atkinson [email protected]