Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do explicit check of CORS headers #3142

Merged
merged 1 commit into from
Aug 31, 2016

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Aug 29, 2016

License: MIT
Signed-off-by: Jakub Sztandera [email protected]

@Kubuxu Kubuxu added the status/in-progress In progress label Aug 29, 2016
@@ -28,10 +28,11 @@ thash='QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn'
test_expect_success "GET to Gateway succeeds" '
curl -svX GET "http://127.0.0.1:$gwport/ipfs/$thash" 2>curl_output
'
cat curl_output
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a stray debugging line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks.

grep "Access-Control-Allow-Origin:" curl_output &&
grep "Access-Control-Allow-Methods:" curl_output &&
grep "Access-Control-Allow-Origin:" curl_output | grep "\*" &&
grep "Access-Control-Allow-Methods:" curl_output | grep GET &&
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will match GETT :P

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu added need/review Needs a review and removed status/in-progress In progress labels Aug 29, 2016
@Kubuxu Kubuxu added this to the ipfs-0.4.3-rc4 milestone Aug 29, 2016
@whyrusleeping
Copy link
Member

Resolves: #2778

@jbenet
Copy link
Member

jbenet commented Aug 31, 2016

What does this resolve? can you copy-paste the line or link to it in the review? or link from there to here?

@jbenet
Copy link
Member

jbenet commented Aug 31, 2016

Okay thanks @whyrusleeping

@jbenet
Copy link
Member

jbenet commented Aug 31, 2016

This LGTM. merge it and link to it in the review issue.

@whyrusleeping whyrusleeping merged commit ea343fb into version/0.4.3-rc4 Aug 31, 2016
@whyrusleeping whyrusleeping deleted the test/CORS/defaults branch August 31, 2016 04:47
@jbenet jbenet mentioned this pull request Aug 31, 2016
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants