Cleanup makefiles #2999
Merged
Cleanup makefiles #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
force-pushed
the
feature/makefile-cleanup
branch
from
ebb32f2
to
8a299fa
Compare
|
|
||
| deps: global-deps bins | ||
|
|
||
| clean: | ||
| rm $(BINS) | ||
| $(MAKE) -C sharness clean | ||
| -rm -rf $(BINS) |
There was a problem hiding this comment.
- prefix makes make ignore return code of rm command.
There was a problem hiding this comment.
Okay then I think it's not needed -- -f makes it ignore non-existing files/dirs anyhow
There was a problem hiding this comment.
Yup, I should clear it up everywhere.
|
LGTM apart from one question ^ |
|
You can squash these: And if we could drop "deps" as a prerequisite here (it is serious overkill), all 5 options could be squashed into two lines. |
|
@thomas-gardner that is awesome trick, Thanks, but we can't drop the |
|
@Kubuxu wanna go ahead and rebase this on master? |
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feature/makefile-cleanup
branch
from
e13bcf8
to
cc60f69
Compare
|
done |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can wait for after release but it shouldn't affect the release in any form either.
We might want to limit number of threads on the sharness or make output sequential of sharness because now they run in parallel.