-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added note about error codes #2915
Conversation
7b9e482
to
f13dabe
Compare
@Kubuxu What do you think about this? |
First thing it fails to build as you used backticks as quotes. The |
I disagree with this - or, rather, I disagree with assuming that this is OK. Offloading knowledge building is important for some things, but I think having a place that says this may be useful to newcomers. I think the code in this PR is easy to put in, and helpful. I would like there to be more special meanings, too. I know where the codes come from - found that part of the code (thanks for linking it! Makes me feel pretty confident in my CR ability) - and there's a comment there saying this, too. Is there any plan to add more codes? |
f13dabe
to
b3f3999
Compare
I think that we should instead do something like manpages do for exit status. See |
b3f3999
to
16434ea
Compare
How does that look? |
16434ea
to
b262802
Compare
How does this look? See #2293 License: MIT Signed-off-by: Richard Littauer <[email protected]>
b262802
to
67a822c
Compare
LGTM |
LGTM |
How does this look? See #2293
License: MIT
Signed-off-by: Richard Littauer [email protected]