Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/buffer err chan #2788

Merged
merged 2 commits into from
Jun 1, 2016
Merged

Fix/buffer err chan #2788

merged 2 commits into from
Jun 1, 2016

Conversation

whyrusleeping
Copy link
Member

If one of the other calls failed, it would return early leaving the other goroutine stranded waiting to return its error.

I also localized the context cancellation to more quickly clean up operations in failure situations.

@whyrusleeping whyrusleeping merged commit acd5765 into master Jun 1, 2016
@whyrusleeping whyrusleeping deleted the fix/buffer-err-chan branch June 1, 2016 20:28
@Kubuxu
Copy link
Member

Kubuxu commented Jun 1, 2016

A bit late but, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants