Pin command fixes

[Stebalien]

1. ipfs pin ls now defaults to "all", not "recursive".
2. ipfs pin rm should respond with Unpinned: HASH, not Pinned: HASH. This is a breaking change.

I don't know how you feel about multiple commits per pull but these were both trivial.

[whyrusleeping]

Maybe instead of creating a new object for the unpinning, we should change the field name of the existing object to something agnostic like 'Pins' or 'Refs'

[Stebalien]

How about Hash (to be consistent with the add command)?

On March 15, 2016 5:23:01 PM EDT, Jeromy Johnson [email protected] wrote:

Maybe instead of creating a new object for the unpinning, we should
change the field name of the existing object to something agnostic like
'Pins' or 'Refs'

---

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#2477 (comment)

Steven Allen

[dignifiedquire]

I don't think making ipfs pin ls default to all is a good idea. The reason being that all is easily very, very large and often much less useful because of that.

[Stebalien]

@whyrusleeping,

Maybe instead of creating a new object for the unpinning, we should change the field name of the existing object to something agnostic like 'Pins' or 'Refs'

I didn't realize this was a list. I changed it to Pins.

@dignifiedquire

That change was made in 29830da (#2208). I just updated the documentation.

[whyrusleeping]

Could we remove the 'Defaults to "All"' from the help string and add .Default("all") to the end of the StringOption constructor?

The down later where we check if typeStrFound { we can drop that check and just rely on the code to pick its own default value correctly.

[whyrusleeping]

an example: https://github.com/ipfs/go-ipfs/blob/master/core/commands/pin.go#L44

[RichardLitt]

@whyrusleeping which change? default to all?

[whyrusleeping]

@RichardLitt relevant to the API:

the json object sent by the pin add and rm commands now has a field of simply Pins instead of Pinned.

It also corrects the documentation to say that "all" is the default instead of "recursive" (no code changes were made for this, all was already the default)

[RichardLitt]

@whyrusleeping Cool. Will update http api when this is merged.

[whyrusleeping]

This looks good to me, @Stebalien could you rebase the changes on latest master?

[Stebalien]

@whyrusleeping Done.

[chriscool]

@Stebalien the change to default to "all" was made following this discussion: #2208 (comment)

To summarize the discussion, the reason is that I added arguments to ipfs pin ls so that one can easily check if a given hash is pinned or not. And when you do ipfs pin ls HASH it is natural to default to "all", so for consistency Juan and myself decided that "all" should always be the default.

[RichardLitt]

Thanks @chriscool.