metrics: rework prometheus integration #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build red -- need to gx the dependencies as well, mh. |
|
@lgierth check out |
|
that import command has a flag to take a json map of packages to existing hashes, so if you want to reuse a package thats already vendored, you should add it there |
added 2 commits
April 11, 2016 19:33
With a proper IpfsCollector object and tests, this time. The collector object makes it easy to add further metrics, like e.g. bitswap wants/provs. License: MIT Signed-off-by: Lars Gierth <[email protected]>
License: MIT Signed-off-by: Lars Gierth <[email protected]>
ghost
|
Heeere we go -- with gxified prometheus dependencies and all. |
ghost
mentioned this pull request
|
LGTM, nice work :) |
ghost
mentioned this pull request
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
metrics: rework prometheus integration This commit was moved from ipfs/kubo@53c94ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peers_total metric used to live deep down in libp2p,
it is now nicely separated, and there's space for even
more metrics. Tests are a good thing too.
The Prometheus library is now gx'ed too. I pinned it on biham.
License: MIT
Signed-off-by: Lars Gierth [email protected]