-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve windows.md #2337
docs: improve windows.md #2337
Conversation
This add a lot of steps that were missing and makes it possible to build on Windows. License: MIT Signed-off-by: Christian Couder <[email protected]>
go get -u github.com/ipfs/go-ipfs | ||
cd %GOPATH%/src/github.com/ipfs/go-ipfs | ||
gx --verbose install --global | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we put this in the makefile or something? it's annoying to ask people to have to install something.
(or is it that Make has problems on windows?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that installing "make" on Windows is usually done by installing Cygwin which takes a lot of time. We should perhaps check if there is a way to install make without Cygwin but it might be for another PR.
LGTM one comment above |
cc @RichardLitt |
This adds more explanations and explain how to properly build with and without Cygwin. License: MIT Signed-off-by: Christian Couder <[email protected]>
In the Travis CI builds there are gx fetching errors like the following:
|
CircleCI has the following error in t0065-active-requests.sh:
|
LGTM |
Thanks for this, I was able to get windows builds working again with minimal fuss. 👍 |
@slothbag great! Happy that it helped! |
docs: improve windows.md
This adds a lot of steps that were missing and makes it possible to build on Windows.
License: MIT
Signed-off-by: Christian Couder [email protected]