Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve windows.md #2337

Merged
merged 2 commits into from
Feb 15, 2016
Merged

docs: improve windows.md #2337

merged 2 commits into from
Feb 15, 2016

Conversation

chriscool
Copy link
Contributor

This adds a lot of steps that were missing and makes it possible to build on Windows.

License: MIT
Signed-off-by: Christian Couder [email protected]

This add a lot of steps that were missing and makes it possible to build on Windows.

License: MIT
Signed-off-by: Christian Couder <[email protected]>
go get -u github.com/ipfs/go-ipfs
cd %GOPATH%/src/github.com/ipfs/go-ipfs
gx --verbose install --global
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we put this in the makefile or something? it's annoying to ask people to have to install something.

(or is it that Make has problems on windows?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that installing "make" on Windows is usually done by installing Cygwin which takes a lot of time. We should perhaps check if there is a way to install make without Cygwin but it might be for another PR.

@jbenet
Copy link
Member

jbenet commented Feb 12, 2016

LGTM one comment above

@whyrusleeping
Copy link
Member

cc @RichardLitt

This adds more explanations and explain how to properly build with and without Cygwin.

License: MIT
Signed-off-by: Christian Couder <[email protected]>
@chriscool
Copy link
Contributor Author

In the Travis CI builds there are gx fetching errors like the following:

gx --verbose install --global
installing package: go-ipfs-0.4.0
  - QmZ4Qi3GaRbjcx28Sme5eMH7RQjGkt8wHxt2a65oLaeFEV not found locally, fetching into /home/travis/gopath/src/gx/ipfs/QmZ4Qi3GaRbjcx28Sme5eMH7RQjGkt8wHxt2a65oLaeFEV
  - fetching QmZ4Qi3GaRbjcx28Sme5eMH7RQjGkt8wHxt2a65oLaeFEV via ipfs api
  - QmZy2y8t9zQH2a1b8q2ZSLKp17ATuJoCNxxyMFG5qFExpt not found locally, fetching into /home/travis/gopath/src/gx/ipfs/QmZy2y8t9zQH2a1b8q2ZSLKp17ATuJoCNxxyMFG5qFExpt
  - fetching QmZy2y8t9zQH2a1b8q2ZSLKp17ATuJoCNxxyMFG5qFExpt via ipfs api
  - Qmazh5oNUVsDZTs2g59rq8aYQqwpss8tcUWQzor5sCCEuH not found locally, fetching into /home/travis/gopath/src/gx/ipfs/Qmazh5oNUVsDZTs2g59rq8aYQqwpss8tcUWQzor5sCCEuH
  - fetching Qmazh5oNUVsDZTs2g59rq8aYQqwpss8tcUWQzor5sCCEuH via ipfs api
  - QmQopLATEYMNg7dVqZRNDfeE2S1yKy8zrRh5xnYiuqeZBn not found locally, fetching into /home/travis/gopath/src/gx/ipfs/QmQopLATEYMNg7dVqZRNDfeE2S1yKy8zrRh5xnYiuqeZBn
  - fetching QmQopLATEYMNg7dVqZRNDfeE2S1yKy8zrRh5xnYiuqeZBn via ipfs api
  - QmYvsG72GsfLgUeSojXArjnU6L4Wmwk7wuAxtNLuyXcc1T not found locally, fetching into /home/travis/gopath/src/gx/ipfs/QmYvsG72GsfLgUeSojXArjnU6L4Wmwk7wuAxtNLuyXcc1T
  - fetching QmYvsG72GsfLgUeSojXArjnU6L4Wmwk7wuAxtNLuyXcc1T via ipfs api
  - QmUBogf4nUefBjmYjn6jfsfPJRkmDGSeMhNj4usRKq69f4 not found locally, fetching into /home/travis/gopath/src/gx/ipfs/QmUBogf4nUefBjmYjn6jfsfPJRkmDGSeMhNj4usRKq69f4
  - fetching QmUBogf4nUefBjmYjn6jfsfPJRkmDGSeMhNj4usRKq69f4 via ipfs api
ERROR: [1 / 6 ] parallel fetch: failed to fetch package: QmUBogf4nUefBjmYjn6jfsfPJRkmDGSeMhNj4usRKq69f4:get: 
ERROR: [2 / 6 ] parallel fetch: failed to fetch package: QmQopLATEYMNg7dVqZRNDfeE2S1yKy8zrRh5xnYiuqeZBn:get: 
ERROR: [3 / 6 ] parallel fetch: failed to fetch package: Qmazh5oNUVsDZTs2g59rq8aYQqwpss8tcUWQzor5sCCEuH:get: 
ERROR: [4 / 6 ] parallel fetch: failed to fetch package: QmYvsG72GsfLgUeSojXArjnU6L4Wmwk7wuAxtNLuyXcc1T:get: 
ERROR: [5 / 6 ] parallel fetch: failed to fetch package: QmZy2y8t9zQH2a1b8q2ZSLKp17ATuJoCNxxyMFG5qFExpt:get: 
ERROR: [6 / 6 ] parallel fetch: failed to fetch package: QmZ4Qi3GaRbjcx28Sme5eMH7RQjGkt8wHxt2a65oLaeFEV:get: 
ERROR: install deps: failed to fetch dependencies
make: *** [deps] Error 1

@chriscool
Copy link
Contributor Author

CircleCI has the following error in t0065-active-requests.sh:

expecting success: 
    grep "log/tail" cmd_out2 | grep "true" > /dev/null

not ok 10 - output looks good
#   
#       grep "log/tail" cmd_out2 | grep "true" > /dev/null
#   

@RichardLitt
Copy link
Member

LGTM

@slothbag
Copy link

Thanks for this, I was able to get windows builds working again with minimal fuss. 👍

@chriscool chriscool added the RFM label Feb 14, 2016
@chriscool
Copy link
Contributor Author

@slothbag great! Happy that it helped!

whyrusleeping added a commit that referenced this pull request Feb 15, 2016
@whyrusleeping whyrusleeping merged commit 7d59baa into master Feb 15, 2016
@whyrusleeping whyrusleeping deleted the improve-windows-doc branch February 15, 2016 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants