Adds offline key resolution on ipns mount.

[hackergrrl]

Uses the local repo when an online public key resolution fails on mount.
This is particularly useful in tests or other young nodes where its
public key may not yet exist on the network.

License: MIT
Signed-off-by: Stephen Whitmore [email protected]

[whyrusleeping]

this mostly looks good to me... it just feels kinda weird to have a resolve fail, then try again a different way... @jbenet thoughts?

[rht]

(~sacrificing C over P?)

[whyrusleeping]

@rht yeah, exactly

[hackergrrl]

This is one of a bunch of different ways we could handle this. I approached this from two UX angles:

1. make mounting tests less flaky (since we create fresh nodes who aren't yet in the dht)
2. make the offline (or just-ipfs initd) UX be less unpleasant

Some alternatives to this PR's approach for each:

1. Require a --local flag to do this kind of local resolution. Lets tests work fine, but creates a divide between "test behaviour" and "production behaviour".
2. Improve the error message and our tests instead to reflect the desire to have online-only mounting. Error messages should reflect that "you cannot mount because you are offline or your pubkey isn't in the dht yet", and our tests should make an explicit "publish" step.

[jbenet]

I think the resolve here should return immediately correctly here. Since there is no network the lookup fails to find any other records beyond the node's own, and thus uses that one.

The solution here (using an offline routing system) is not the right one; we should be fixing the underlying problems in "why resolve is not returning our own record" as valid.

[hackergrrl]

Agreed. I'm discussing now how we'll achieve this at the routing level in IRC (#ipfs). Closing this PR, since the fix isn't going to resemble this approach.

[radfish]

For those landing here via a search: since 0.4.19 offline resolution is supported via --offline flag either to the resolve command or globally.