do resolve operations concurrently #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,23 +133,41 @@ func (r *routingResolver) resolveOnce(ctx context.Context, name string) (path.Pa | |||
| // /ipns/<name> | |||
There was a problem hiding this comment.
Should the "name should be a multihash" comment be above the block on line 125?
There was a problem hiding this comment.
ah, probably. I'll go ahead and change that here
|
LGTM. Appveyor seems to be confused ("Specify a project or solution file. The directory does not contain a project or solution file."). Known issue? |
|
appveyor config is not merged yet: #2137 |
whyrusleeping
force-pushed
the
feat/faster-resolve
branch
from
0f7213f
to
19b2f89
Compare
License: MIT Signed-off-by: Jeromy <[email protected]>
| }() | ||
|
|
||
| for i := 0; i < 2; i++ { | ||
| err = <-resp |
There was a problem hiding this comment.
is this much faster than a WaitGroup? (waitgroups are less error prone)
There was a problem hiding this comment.
waitgroups don't allow us to easily return errors. Otherwise its functionally identical to a waitgroup
|
LGTM other than waitgroup comment o/ |
jbenet
added a commit
that referenced
this pull request
Jan 15, 2016
do resolve operations concurrently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve the ipns record and public key concurrently for a bit of speedup on name resolves.
License: MIT
Signed-off-by: Jeromy [email protected]